Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to windows-2025 runner #1039

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −5
Draft

Update to windows-2025 runner #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
matrix:
os:
- ubuntu-24.04
- windows-latest
- windows-2025
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ defaults:

jobs:
inspect_runner:
runs-on: windows-2022
runs-on: windows-2025
steps:
- name: Print some variables which is applied in GH-617
run: |
Expand All @@ -53,7 +53,7 @@ jobs:
#
# Not Terraform :)
terraform:
runs-on: windows-2022
runs-on: windows-2025
steps:
- name: Prepare Windows Defender
# https://github.com/actions/runner-images/issues/855#issuecomment-626692949 may help to understand
Expand Down Expand Up @@ -153,11 +153,14 @@ jobs:
# name: MpCmdRun-logs
# path: MpCmdRun-logs/**
#
# Do not write depending winget logcs for now
# Do not write depending winget logics until windows-2025 officially supports it
# - windows-2025 definitely enable it by default
# - windows-2022 may realize with the action: https://github.com/microsoft/winget-cli/issues/3872
# - proposal: https://github.com/actions/runner-images/issues/910
# - note: https://github.com/microsoft/winget-cli/blob/b07d2ebb7d865f95320e2bc708a2d1efb2152c5a/README.md#L14
- name: Inspect tool versions
run: |
winget --version
wsl --version
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kachick/dotfiles/actions/runs/12764510432/job/35576813998?pr=1039

Run winget --version
  winget --version
  wsl --version
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command "$PSNativeCommandUseErrorActionPreference = $true; $ErrorActionPreference = 'stop'; . '{0}'"
  
v1.6.101[2](https://github.com/kachick/dotfiles/actions/runs/12764510432/job/35576813998?pr=1039#step:12:2)1
WSL version: 2.[3](https://github.com/kachick/dotfiles/actions/runs/12764510432/job/35576813998?pr=1039#step:12:3).26.0

Kernel version: 5.15.167.[4](https://github.com/kachick/dotfiles/actions/runs/12764510432/job/35576813998?pr=1039#step:12:4)-1

WSLg version: 1.0.65

MSRDC version: 1.2.5620

Direct3D version: 1.611.1-81528511

DXCore version: 10.0.26100.1-240331-1435.ge-release

Windows version: 10.0.26100.260[5](https://github.com/kachick/dotfiles/actions/runs/12764510432/job/35576813998?pr=1039#step:12:5)

🎉

- name: Rebel against unacceptable default
run: |
.\dist\winit-reg.exe list
Expand Down
Loading