Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Marshal with TOML in snapshots format #503

Merged
merged 11 commits into from
Mar 20, 2024
Merged

Replace Marshal with TOML in snapshots format #503

merged 11 commits into from
Mar 20, 2024

Conversation

kachick
Copy link
Owner

@kachick kachick commented Mar 9, 2024

Resolves #501

@kachick kachick mentioned this pull request Mar 10, 2024
Draft
@kachick
Make sure toml-rb raises similar error as taplo for distant future
e24a8ca 
```
Failed to parse input on line 24007 at offset 24 (TomlRB::ParseError)
to_time = 10889-07-21T15:54:33Z
```
@kachick
Copy link
Owner Author

kachick commented Mar 10, 2024

🤷‍♂️ https://github.com/toml-lang/toml/blob/2431aa308a7bc97eeb50673748606e23a6e0f201/toml.abnf#L180

date-fullyear  = 4DIGIT

Using TOML as serializer for ULID and UUIDv7 timestamp will not fit...? 🤔 uuid6/uuid6-ietf-draft#23

@kachick
Copy link
Owner Author

kachick commented Mar 12, 2024

💭 ULID longa, vita brevis

@kachick
Copy link
Owner Author

kachick commented Mar 12, 2024

https://zenn.dev/qnighy/articles/33a85dcf62bb89 👀

@kachick
Copy link
Owner Author

kachick commented Mar 20, 2024

https://sdlang.org/

https://github.com/dlang-community/SDLang-D/blob/634f65cb34230a4bbaff6d40f31288616edea0de/src/sdlang/lexer.d#L937-L942

		biTmp = BigInt(yearStr);
		if(isNegative)
			biTmp = -biTmp;
		if(biTmp < int.min || biTmp > int.max)
			error(tokenStart, "Date's year is out of range. (Must fit within a 32-bit signed int.)");
		auto year = biTmp.toInt();

👁️

@kachick
Copy link
Owner Author

kachick commented Mar 20, 2024

https://gihyo.jp/article/2024/01/ruby3.3-lrama
https://github.com/ruby/lrama

@kachick
Copy link
Owner Author

kachick commented Mar 20, 2024

https://news.ycombinator.com/item?id=31225845

@kachick kachick changed the title Add script for converting dump to json Prefer readable serialization format rather than marshal in snapshot Mar 20, 2024
@kachick kachick mentioned this pull request Mar 20, 2024
Closed
@kachick kachick changed the title Prefer readable serialization format rather than marshal in snapshot Prefer human readable serialization format rather than marshal in snapshot Mar 20, 2024
@kachick kachick changed the title Prefer human readable serialization format rather than marshal in snapshot Replace Marshal with TOML in snapshot formats Mar 20, 2024
@kachick kachick changed the title Replace Marshal with TOML in snapshot formats Replace Marshal with TOML in snapshots format Mar 20, 2024
@kachick kachick marked this pull request as ready for review March 20, 2024 06:27
@kachick kachick merged commit 6304ddc into main Mar 20, 2024
16 checks passed
@kachick kachick deleted the readable-snapshot branch March 20, 2024 06:29
kachick added a commit that referenced this pull request Mar 20, 2024
@kachick
Refactor converting hash with struct
9fae027 
Update #503
@kachick kachick mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace marshal with something for human readable serialization format in snapshots
1 participant
@kachick