Fix up some config etc. (attempt 2) #1018
Conversation
🦋 Changeset detectedLatest commit: 31ce1df The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
webpro
force-pushed
the
chore/fix-up-config
branch
2 times, most recently
from
7eede98 to
ff2f205
Compare
webpro
requested review from
alber70g,
eileenmguo,
sstraatemans,
timoheddes,
javadkh2 and
Takadenoshi
as code owners
| @@ -0,0 +1,27 @@ | |||
| --- | |||
There was a problem hiding this comment.
do we need 2 changesets?
There was a problem hiding this comment.
I think it's coming from the fact I branched from another feat branch. I'll keep it in mind. Either way, it's all none so it'll basically end up nowheere.
| @@ -76,16 +76,15 @@ | |||
| "@vanilla-extract/jest-transform": "1.1.1", | |||
| "@vanilla-extract/next-plugin": "2.3.1", | |||
| "@walletconnect/types": "~2.8.1", | |||
| "@webpro/next-translate-plugin": "^2.6.3", | |||
There was a problem hiding this comment.
- Ugly: https://github.com/kadena-community/kadena.js/pull/1018/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L14
- Fix: feat: add basePath as config option aralroca/next-translate-plugin#55
tl/dr; that plugin doesn't support custom base path cq monorepos so I fixed it. We'll go back to the original once it's sorted downstream.
There was a problem hiding this comment.
Could you add a section in the readme or amend this commit to add this PR in the message? It's easier to find why we have this in transition for the future
packages/apps/docs/package.json
Outdated
| @@ -57,7 +57,7 @@ | |||
| "mdast-util-to-markdown": "~1.5.0", | |||
| "mdast-util-to-string": "~3.2.0", | |||
| "mobx": "~6.9.0", | |||
| "next": "13.5.3", | |||
| "next": "13.4.5", | |||
There was a problem hiding this comment.
what is the reason for downgrading next version here?
There was a problem hiding this comment.
We have a policy in the repo to make sure the version of a package is the same across the monorepo. First I tried to upgrade the others, but got some error, so then downgraded this one.
There was a problem hiding this comment.
hm the new version was helping us with some performance.
not really happy with this one
There was a problem hiding this comment.
I think it makes sense for packages like next to have an exception, this is something close to the app itself, you don't want to force the whole repo to upgrade it at once every time we upgrade in the future. Already proven by the fact that you had troubles doing it now.
next isn't some bundled dependency that is going to give issues in builds or increase bundle sizes.
There was a problem hiding this comment.
Next.js has a dependency on React. Component libs too. So to prevent any issues here (we've had them before) we should stay in sync, especially libs like Next.js + React.
| @@ -110,8 +110,7 @@ | |||
| "micromark-extension-frontmatter": "~1.1.0", | |||
| "mini-css-extract-plugin": "2.7.6", | |||
| "openapi-types": "~12.1.3", | |||
| "prettier": "~3.0.0", | |||
| "prettier-plugin-packagejson": "^2.4.5", | |||
| "prettier": "~3.0.3", | |||
There was a problem hiding this comment.
if we're allowing prettier at root level dependency, then why are we keeping prettier again here?
There was a problem hiding this comment.
To keep them as much self-contained/isolated as possible.
webpro
force-pushed
the
chore/fix-up-config
branch
from
f39d2f6 to
db721c5
Compare
webpro
force-pushed
the
chore/fix-up-config
branch
from
fe1d386 to
5907e98
Compare
webpro
force-pushed
the
chore/fix-up-config
branch
from
5907e98 to
930ff26
Compare
This PR improves/fixes some configuration and dependencies in our monorepo.
(Duplicating #1008, as CI runs kept getting cancelled (devops cancel culture?). Eventually traced it down to a combo of adding the root workspace (
- '.') topnpm-workspace.yamland"extends": ["//"]to the rootturbo.json(which turbo documents to do). Oh well, let's move on.)Here's the list of commits: