Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/signWithChainweaver) KIP-0015 update #156

Merged
merged 39 commits into from
Feb 27, 2023
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
d484696
update /quickSign to /quicksign
Feb 2, 2023
8fadb38
rush change
Feb 2, 2023
eac3f45
update requestBody
Feb 15, 2023
ad723e0
add null to ISignature, pubkey => pubKey in addSignatures, update Cha…
Feb 16, 2023
981dafa
fix import and rewrite
Feb 16, 2023
8b5c60a
update signWithChainweaver tests
Feb 17, 2023
202c362
run rush change
Feb 17, 2023
b6a9ea3
minor fix
Feb 17, 2023
cfff536
add failure / noSig cases in Chainweaver Response and Error
Feb 20, 2023
1984929
add noSig case to the test
Feb 21, 2023
377edcd
handle nullable string value
Feb 21, 2023
63dde22
add eslint-disable to prevent null warning
Feb 22, 2023
b9c5dbb
add eslint-disable-next-line for no-new-null errors
Feb 22, 2023
7732e68
Merge branch 'fix/update-quicksign' of https://github.com/kadena-comm…
Feb 22, 2023
48e833b
remove eslint-disable
Feb 22, 2023
dd3f5fe
wip: define separate types for pact and signing api
alber70g Feb 23, 2023
5c6a6b9
fix ISignature to non-null and use ISignatureJson
Feb 24, 2023
32e259b
rush change
Feb 24, 2023
03bbcb2
merge master
Feb 24, 2023
eb60fb3
remove open-api generatioin
Feb 24, 2023
06fb490
add open-api
Feb 24, 2023
5472984
update expected value in test
Feb 24, 2023
fc72866
Update packages/libs/client/src/signing/tests/signWithChainweaver.tes…
ggobugi27 Feb 24, 2023
69f6e0c
Update packages/libs/chainweb-node-client/src/tests/local.test.ts
ggobugi27 Feb 24, 2023
6e23872
remove console.log
Feb 24, 2023
c2f960d
Merge branch 'fix/update-quicksign' of https://github.com/kadena-comm…
Feb 24, 2023
929df98
add IQuicksignResponseBody
Feb 24, 2023
9962020
Update packages/libs/chainweb-node-client/src/tests/send.test.ts
ggobugi27 Feb 24, 2023
4489e46
revert to master
ggobugi27 Feb 24, 2023
bbf964f
Update index.ts
ggobugi27 Feb 24, 2023
13f0588
Update index.ts
ggobugi27 Feb 24, 2023
6a0a13e
revert to master
ggobugi27 Feb 24, 2023
07ab924
Update index.ts
ggobugi27 Feb 24, 2023
a747ba2
Update index.ts
ggobugi27 Feb 24, 2023
4bf5e95
chore: remove generated from openapi spec
alber70g Feb 24, 2023
500aae2
chore: add type to differentiate between quicksign success and response
alber70g Feb 24, 2023
a9fc845
fix(client): test with order when converting unsignedTransaction to I…
alber70g Feb 24, 2023
ad7b4e3
Merge branch 'fix/update-quicksign' of https://github.com/kadena-comm…
Feb 27, 2023
cf51b6c
add test coverage
Feb 27, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@kadena/chainweb-node-client",
"comment": "update ISignature to non-null ",
"type": "patch"
}
],
"packageName": "@kadena/chainweb-node-client"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@kadena/chainweb-node-client",
"comment": "",
"type": "none"
}
],
"packageName": "@kadena/chainweb-node-client"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@kadena/client",
"comment": "update /quickSign to /quicksign in client/signWithChainweaver",
"type": "patch"
}
],
"packageName": "@kadena/client"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@kadena/client",
"comment": "Update with KIP 0015 signing api standard",
"type": "patch"
}
],
"packageName": "@kadena/client"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@kadena/types",
"comment": "add null type to IUnsignedTransaction sig",
"type": "minor"
}
],
"packageName": "@kadena/types"
}
31 changes: 31 additions & 0 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion common/config/rush/repo-state.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
{
"pnpmShrinkwrapHash": "ba8b267af803a5ec6df145e148a5a9f8ae2b3ba7",
"pnpmShrinkwrapHash": "f6ff508d606bbd16187ce03e9a87eb8d0ce6e71a",
"preferredVersionsHash": "bf21a9e8fbc5a3846fb05b4fa0859e0917b2202f"
}
1 change: 1 addition & 0 deletions packages/libs/chainweb-node-client/.eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/src/openapi/
5,194 changes: 5,194 additions & 0 deletions packages/libs/chainweb-node-client/openapi/chainweb.json

Large diffs are not rendered by default.

Loading