Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spv expiration #2050

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

spv expiration #2050

wants to merge 4 commits into from

Conversation

chessai
Copy link
Contributor

@chessai chessai commented Nov 26, 2024

No description provided.

@chessai chessai marked this pull request as draft December 4, 2024 22:02
@chessai chessai force-pushed the chessai/spv-expiration branch 2 times, most recently from 8632271 to 6746f22 Compare December 9, 2024 21:26
@chessai
Add expiration to SPV output proofs
3394f73 
Change-Id: I81f175cee19c8a19a1a14af0beb0f7bdef3cb9c3

wip spv expiration

Change-Id: If3ae29fb08b9c0b20db330a3953bde9c8b4bddc6

spv proof expiration test fix

Change-Id: I5965386a4594281855bf4afbdc1a824aa6ddff48
@chessai
implement HeaderOracle and get SPV functions to use that
a3ce78b 
Change-Id: Ie1996cf9f50c73f16a4e5a1fa30aea67e648d188

remove redundant prett-show dependency

Change-Id: I2a4e0ca1a615c0edf28576ee763af6b16aebc234
@chessai
set testnet spv proof expiration window to 23_040
95f549e 
Change-Id: I65b8c82d9c26b327a9052b5091a9a8930abd2538
@chessai chessai force-pushed the chessai/spv-expiration branch from 6b3ba4c to 95f549e Compare December 13, 2024 03:27
edmundnoble
edmundnoble approved these changes Dec 13, 2024
View reviewed changes
test/unit/Chainweb/Test/Pact/PactSingleChainTest.hs

runCut :: (HasCallStack) => ChainwebVersion -> ChainMap PactExecutionService -> TestBlockDb -> TimeSpan Micros -> IO (ChainMap PayloadWithOutputs)
runCut v queues bdb timeOffset = do
--runExceptT $ do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleto

test/unit/Chainweb/Test/Pact/PactSingleChainTest.hs
withDelegateMempool $ \srcDm ->
withDelegateMempool $ \targetDm ->
testCase "spvExpiration" $ do
T.putStrLn ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@edmundnoble edmundnoble marked this pull request as ready for review December 13, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundnoble edmundnoble edmundnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chessai @edmundnoble