Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leading slash from the name #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mesuutt
Copy link

@mesuutt mesuutt commented Nov 21, 2013

This is related to #13. A few things were left in that patch. This one is a bit cleaner and simpler. Hope it gets merged.

@twigs
Copy link

twigs commented Dec 2, 2013

@mesuutt this is the same as my last pull request in #13,just without the documentation update and the test. Anyway, I hope one of the pull requests gets merged eventually.

@mesuutt
Copy link
Author

mesuutt commented Dec 2, 2013

@twigs I know little English, so I hope you understand me.
I looked at your last commit and I see your code has unnecessary code(there is strip_slash parameter still exist in code but I think it is not necessary). You know @kadirpekel don't merging your patch for one month and didn't write any comment to the pull request. After that I started to think @kadirpekel did not merge your patch because your commit not clear and there are unnecessary code in your patch still. So I make this pull request. But @kadirpekel don't merge my patch too :)

I did not care about merge my patch. I care about this bug should be fixed at @kadirpekel's repo.

Yes I forgot write test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants