#74 Feat: add post, comment, postimage domain #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumzen
reviewed
Oct 9, 2024
yumzen
requested review from
woogieon8on
and removed request for
boogiewooki02
woogieon8on
reviewed
Oct 11, 2024
There was a problem hiding this comment.
UMC에서 인스타 클론코딩 스터디하면서 작성한 ERD입니다
댓글, 좋아요 엔티티 구현할 때 참고하세욥
댓글, 대댓글 엔티티를 따로 두는 것보다 지은이 말처럼 댓글 엔티티 하나로 관리하는 방법이 디비 구조가 간결해져서 좋을 것 같습니다!
yumzen
reviewed
Nov 4, 2024
src/main/java/kahlua/KahluaProject/dto/post/response/PostCreateResponse.java
Show resolved
Hide resolved
woogieon8on
reviewed
Nov 5, 2024
| } | ||
|
|
||
| public static List<PostImage> toPostImage(List<PostImageCreateRequest> postImageCreateRequests, Post post) { | ||
| return Optional.ofNullable(postImageCreateRequests) |
There was a problem hiding this comment.
null 여부를 컨버터에서 검증하니까 서비스 로직이 훨씬 깔끔해지네요!! 굿 굿
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)