#76 Feat: ApplyInfo, TicketInfo entity 생성 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjiyun
reviewed
Oct 9, 2024
| import java.time.LocalDateTime; | ||
|
|
||
| @JsonNaming(PropertyNamingStrategies.SnakeCaseStrategy.class) | ||
| public record ApplyInfoData( |
There was a problem hiding this comment.
record를 사용하면 값을 변경할 수 없어서 나중에 날짜를 착각했거나 계획 변경이 있었을 때 변경이 용이하지 않는다는 단점이 있을 수도 있을 것 같습니다. record를 사용하신 이유가 있을까요?
There was a problem hiding this comment.
record는 어노테이션 사용을 최소화하고, 사실상 data 안에 있는 내용들은 update 외의 요청에서는 변경이 일어나야 하지 않아야 하기 때문에 사용했습니다! 나중에 수정 요청들어와도 update 메소드 생성하여 변경할 수 있습니다!
woogieon8on
reviewed
Oct 11, 2024
There was a problem hiding this comment.
ApplyInfo 엔티티는 간단하게 id와 나머지 지원서 세부내용으로 이루어져 있는데, 세부내용을 vo로 묶어 관리할 때 유지보수 외에 성능 측면에서도 이점이 있는지 궁금합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
ApplyInfoData, TicketInfoData 모두 데이터들을 모두 필드로 관리할 필요는 없을 것 같아서 Json 타입으로 데이터 저장하려고 합니다!
스크린샷 (선택)
💬리뷰 요구사항(선택)