Feat: 동방 예약 기능 구현 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumzen
approved these changes
Nov 11, 2024
| Reservation reservation = reservationRepository.findById(reservationId) | ||
| .orElseThrow(() -> new GeneralException(ErrorStatus.RESERVATION_NOT_FOUND)); | ||
|
|
||
| reservationRepository.deleteById(reservationId); |
There was a problem hiding this comment.
status에 CANCELLED를 만들어둔 것 같은데 status를 안쓰고 delete로 관리하신 이유가 있으신가요??
There was a problem hiding this comment.
죄송합니다 제가 추가해두고 깜빡했네요,,, 로직 수정하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)