Feature/export private key as jwk #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add translations and dialog box radio button for exporting privaye key as JWK
Existing selector of the private key format needs to handle JWK. JWK supports aside of RSA and EdDSA subset of EC curves. Passing just KeyPairType is not sufficient, so this dialog now uses PrivateKey instance to decide which output formats should be enabled This is part of (kaikramer#438)
Reuse existing KSE utility code in JWK public key exporter. Extract JWK common code that is shared by the public and private key exporters This is part of (kaikramer#438)
This is part of (kaikramer#438)
This is part of (kaikramer#438)
Export instances of RSAPrivateCrtKey as JWK This is part of (kaikramer#438)
Export instances of ECPrivateKey as JWK This is part of (kaikramer#438)
provide static method JwkPublicKeyExporter.isPublicKeyTypeExportable which uses existing KSE functionality to check if key type can be exported to Jwk, without creating instance of the JwkPublicKeyExporter class
kaikramer
reviewed
Jan 3, 2025
kse/src/main/resources/org/kse/gui/dialogs/importexport/resources_de.properties
Outdated
Show resolved
Hide resolved
|
Nice PR, thanks a lot! |
|
always glad to help! |
I haven't fully tested it, but it seems complete for me. In general I like to keep the issues open until the actual release happens. So they are easier to find if someone else wants the same feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KSE now is able to export private keys as JWK.
Existing code for exporting public keys has been simplified and refactored.