Driver Listener List to Set

kairoh · Oct 7, 2023 · 139ec38 · 139ec38
1 parent 90830ea
commit 139ec38
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -2,5 +2,6 @@
     "java.configuration.updateBuildConfiguration": "automatic",
     "githubPullRequests.ignoredPullRequestBranches": [
         "master"
-    ]
+    ],
+    "java.jdt.ls.vmargs": "-XX:+UseParallelGC -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -Dsun.zip.disableMemoryMapping=true -Xmx2G -Xms100m -Xlog:disable"
 }
diff --git a/driver/src/main/java/studio/driver/service/fs/FsStoryTellerAsyncDriver.java b/driver/src/main/java/studio/driver/service/fs/FsStoryTellerAsyncDriver.java
@@ -16,7 +16,9 @@
 import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.Comparator;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 import java.util.UUID;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionStage;
@@ -58,8 +60,8 @@ public class FsStoryTellerAsyncDriver implements StoryTellerAsyncDriver {
     @Setter
     private SdPartition sdPartition = null;
 
-    private List<DevicePluggedListener> pluggedlisteners = new ArrayList<>();
-    private List<DeviceUnpluggedListener> unpluggedlisteners = new ArrayList<>();
+    private Set<DevicePluggedListener> pluggedlisteners = new HashSet<>();
+    private Set<DeviceUnpluggedListener> unpluggedlisteners = new HashSet<>();
 
     public FsStoryTellerAsyncDriver() {
         // Initialize libusb, handle and propagate hotplug events

diff --git a/driver/src/main/java/studio/driver/service/raw/RawStoryTellerAsyncDriver.java b/driver/src/main/java/studio/driver/service/raw/RawStoryTellerAsyncDriver.java
@@ -21,7 +21,9 @@
 import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.Comparator;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 import java.util.Optional;
 import java.util.UUID;
 import java.util.concurrent.CompletableFuture;
@@ -66,8 +68,8 @@ public class RawStoryTellerAsyncDriver implements StoryTellerAsyncDriver {
     static final int PACK_TRANSFER_CHUNK_SECTOR_SIZE = 5000;    // 2.5 MB
 
     private Device device = null;
-    private List<DevicePluggedListener> pluggedlisteners = new ArrayList<>();
-    private List<DeviceUnpluggedListener> unpluggedlisteners = new ArrayList<>();
+    private Set<DevicePluggedListener> pluggedlisteners = new HashSet<>();
+    private Set<DeviceUnpluggedListener> unpluggedlisteners = new HashSet<>();
 
     @Getter
     @Setter