Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pegasus' related repository #184

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Add pegasus' related repository #184

merged 4 commits into from
Oct 18, 2021

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Oct 18, 2021 •
edited
Loading

I'm submitting a...

[ √ ] Other (Refactoring, Added tests, Documentation, ...)

Does this PR introduce a breaking change?

[ ] Yes
[ √ ] No

@Smityz Smityz requested a review from a team as a code owner October 18, 2021 04:20
@Smityz Smityz changed the title Update apache.ts Add pegasus' related repository Oct 18, 2021
@huan
Copy link
Collaborator

huan commented Oct 18, 2021

Welcome!

Could you please also add your open source community to

So that our OSSChat community can know more about your project?

Thank you very much!

@Smityz
Copy link
Contributor Author

Smityz commented Oct 18, 2021

Welcome!

Could you please also add your open source community to

So that our OSSChat community can know more about your project?

Thank you very much!

Here
#79 (comment)

huan
huan requested changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your project!

Please change the config code and make the CI green, then we will be able to merge it.

Welcome!

@Smityz
Copy link
Contributor Author

Smityz commented Oct 18, 2021

Need approve

@huan
Copy link
Collaborator

huan commented Oct 18, 2021

The best way is to run npm test before the git push, which can make it faster to fix problems locally.

@Smityz
Copy link
Contributor Author

Smityz commented Oct 18, 2021

npm test successfully, can you help me to approve again?

@huan huan enabled auto-merge (squash) October 18, 2021 12:43
huan
huan approved these changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit 5289f80 into kaiyuanshe:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smityz @huan