Skip to content

Make all color channels f64. #1984

Make all color channels f64.

Make all color channels f64. #1984

Triggered via pull request September 20, 2024 19:03
@kajkaj
opened #199
f64-color
Status Failure
Total duration 31s
Artifacts

rust.yml

on: pull_request
Matrix: All Tests
Matrix: Test on MacOS
Matrix: Old rust
Matrix: Test on Windows
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 5 warnings
Clippy: rsass/src/value/colors/mod.rs#L27
you are implementing `Ord` explicitly but have derived `PartialOrd`
Clippy
Process completed with exit code 101.
Clippy: rsass/src/sass/functions/color/mod.rs#L133
unneeded `return` statement
Clippy: rsass/src/sass/functions/color/mod.rs#L158
useless conversion to the same type: `f64`
Clippy: rsass/src/value/colors/hsla.rs#L30
clamp-like pattern without using clamp function
Clippy: rsass/src/value/colors/hwba.rs#L27
the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable
Clippy: rsass/src/variablescope.rs#L523
this manual char comparison can be written more succinctly