Global math #184
Merged
Global math #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaj
force-pushed
the
global-math
branch
8 times, most recently
from
4b36dad to
821599f
Compare
kaj
added a commit
that referenced
this pull request
Nov 11, 2023
Released 2023-11-11. . * Filter out placeholder selectors when writing the resulting css (they are still parsed of the internal data representation, so they can be used when implementing `@extend`) (PR #180). * Filter out some other illegal / never-matching selectors (PR #181). * Some improvements in plain css value parsing: - trailing comma and space separated lists in function arguments. - unqoted urls (contining slash and dot) in function arguments. - Negative numbers and numbers starting with a decimal dot. - unicode-ranges. * Allow at-rules in at-rules when parsing plain css. * Refactored function name/plain string handling in scss values to not parse the same unquoted string twice. * Remove separate backref member from `css::Selectors` for cleanup before implementing more selector functions. Instead, add it to an internal struct `SelectorCtx` (PR #179). * Implemented a bunch of css math functions. They differ from the functions in the math module in that they fallback to themself if the answer cant be calculated but isn't obviously wrong (e.g. `min(var(--gap), 2em)` is preserved while `min(1em, 2em)` is evaluated to `1em` and `min(1s, 1em)` yields an error). This also includes some improvements in handling numeric zeroes and infinities. (PR #184). * Implemented css relative color functions (PR #185). * Simplify units early in numeric division and multiplication. I think this is a bit uglier, but it is more consistent with dart sass. * Refactored some parsers for less backtracking, making it easier to point parse errors at the right place in the code and maybe making parsing slightly more efficient. * Improve selector / name parsing by beeing more restrictive (PR #183). * Updated sass-spec test suite to 2023-10-31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.