WIP: Provide join_html and join_to_html. #88
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible solution to #85 .
Questions / things to test:
join_html
andjoin_to_html
good names for the functions?DoesIt does not, and would be rather hard to fix at the moment. But inline templates with arguments would be a separate issue that would fix it.join_html
work with inline subtemplates when used in templates?impl ToHtml
, but currently bothjoin_html
andjoin_to_html
returnsBox<dyn ToHtml>
, as a trait function apparently cannot returnimpl Trait
. They could also returnHtmlJoiner<...>
, but then that class (which I consider an implementation detail) would have to be public, and the generic type arguments would be inconveniently long.join_html
andjoin_to_html
understandable?