feat(client): add PeekLogStream to the client #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijsong
force-pushed
the
add-peeklogstream
branch
2 times, most recently
from
d9aa6f9 to
a775133
Compare
ijsong
force-pushed
the
add-peeklogstream
branch
2 times, most recently
from
ab1bb44 to
d977774
Compare
hungryjang
reviewed
Nov 24, 2022
| case varlogpb.LogStreamStatusRunning, varlogpb.LogStreamStatusSealed: | ||
| mu.Lock() | ||
| defer mu.Unlock() | ||
| if first.LLSN < lsrmd.LocalLowWatermark.LLSN { |
There was a problem hiding this comment.
Does it means highest LocalLowWatermark?
There was a problem hiding this comment.
Yes, it is. Since the trim operation removes from the front of log entries, PeekLogStream takes the largest one.
hungryjang
approved these changes
Dec 6, 2022
This patch adds a new API called PeekLogStream to the client. The PeekLogStream returns sequence numbers at the first and last log entries. Users using LogStreamMetadata or LogStreamReplicaMetadata to fetch the sequence numbers should use PeekLogStream. PeekLogStream has the benefits over the ogStreamMetadata or LogStreamReplicaMetadata. - It does not send users useless and complex information about log stream replicas. - It prevents users from getting too detailed information about log stream replicas. - It takes accounts for the status of log stream replicas; thus, it returns more accurate first and last log sequence numbers of the log stream. Resolves kakao#239
ijsong
force-pushed
the
add-peeklogstream
branch
from
d977774 to
e872677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This patch adds a new API called PeekLogStream to the client. The PeekLogStream returns sequence
numbers at the first and last log entries. Users using LogStreamMetadata or LogStreamReplicaMetadata
to fetch the sequence numbers should use PeekLogStream.
PeekLogStream has the benefits over the ogStreamMetadata or LogStreamReplicaMetadata.
log sequence numbers of the log stream.
Which issue(s) this PR resolves
Resolves #239