refactor(logstream): use beginLLSN in Replicate method #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces llsnList with beginLLSN in the Replicate method. Since LLSNs in llsnList are strictly sequential, beginLLSN and the length of dataList are sufficient. The corresponding tests have been updated to reflect this change. The llsn field in ReplicateRequest has been deprecated and will be removed soon.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## use_grpc_codec_v2 #958 +/- ##
=====================================================
- Coverage 80.19% 79.94% -0.26%
=====================================================
Files 179 179
Lines 21565 21569 +4
=====================================================
- Hits 17295 17244 -51
- Misses 3483 3528 +45
- Partials 787 797 +10 ☔ View full report in Codecov by Sentry. |
hungryjang
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This commit replaces llsnList with beginLLSN in the Replicate method. Since
LLSNs in llsnList are strictly sequential, beginLLSN and the length of dataList
are sufficient. The corresponding tests have been updated to reflect this
change. The llsn field in ReplicateRequest has been deprecated and will be
removed soon.