refactor(storagenode): remove synchronous Append #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor_sn_committer_to_remove_requirecommitwaittasks_parameter #970 +/- ##
====================================================================================================
+ Coverage 79.98% 80.03% +0.05%
====================================================================================================
Files 178 178
Lines 21484 21416 -68
====================================================================================================
- Hits 17183 17140 -43
+ Misses 3507 3488 -19
+ Partials 794 788 -6 ☔ View full report in Codecov by Sentry. |
hungryjang
reviewed
Feb 1, 2025
hungryjang
approved these changes
Feb 3, 2025
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
b74daea to
efdf19f
Compare
ijsong
force-pushed
the
refactor_storagenode_remove_synchronous_append
branch
from
4f23b35 to
99f94ef
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
efdf19f to
d89b402
Compare
ijsong
force-pushed
the
refactor_storagenode_remove_synchronous_append
branch
from
99f94ef to
3a32676
Compare
This PR removes the synchronous Append method from Executor, which is unused code. It also updates tests to use the asynchronous AppendAsync method and ensures proper handling of AppendTask in tests.
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
d89b402 to
39badb5
Compare
ijsong
force-pushed
the
refactor_storagenode_remove_synchronous_append
branch
from
3a32676 to
c022f54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes the synchronous Append method from Executor, which is unused
code. It also updates tests to use the asynchronous AppendAsync method and
ensures proper handling of AppendTask in tests.