Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ADA-1064): Transcript search results inaccessible to screen reader followup from ADA-16 #211

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Jul 9, 2024

Issue:
When user pick an instance of the search result, there is no quick mechanism to get to the line in the transcript with the word from the search box.

Solution:
Move the focus to the current line from the search result

Solves ADA-1064

@Tzipi-kaltura Tzipi-kaltura merged commit 46c6dcd into master Jul 22, 2024
6 checks passed
semarche-kaltura added a commit that referenced this pull request Aug 9, 2024
…en reader followup from ADA-16 (#211)"

This reverts commit 46c6dcd.
semarche-kaltura added a commit that referenced this pull request Aug 19, 2024
* Revert "fix(ADA-1064): Transcript search results inaccessible to screen reader followup from ADA-16 (#211)"

This reverts commit 46c6dcd.

* ADA-1064: announce search results

* fix(FEC-14077): to search result button

* fix(FEC-14077): jump to search result feature

* fix(FEC-14077): add tests

* fix(FEC-14077): address comments

* chore: upd cypress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants