setup(css-library): setup tailwind for all apps with global config in ui package #15
Conversation
sidarth-23
requested review from
yogai53,
yaju09 and
elizabeththomas92
as code owners
|
@sidarth-23 Please resolve conflict. |
Resolved |
| @@ -0,0 +1,17 @@ | |||
| import type { Config } from "tailwindcss"; | |||
|
|
|||
There was a problem hiding this comment.
Create new project for Tailwind.
There was a problem hiding this comment.
I'm done with it. But I'm unable to squash the commits due to git merge in between the commits
| "tailwindcss": "^3.4.1", | ||
| "postcss": "^8.4.33", | ||
| "autoprefixer": "^10.4.17", | ||
| "typescript": "^5.3.3" |
There was a problem hiding this comment.
Please check other dependencies and ensure if it is really needed for the project.
There was a problem hiding this comment.
I checked with the projects using it and found that it works only if tailwind is installed. But not sure if it's required in the config package. I'll test it out update the status here
There was a problem hiding this comment.
The intuition was correct and I did not need the node-modules in tailwind-config package.
Except for the tailwindcss. I needed it to get the type of config file which is there in tailwindcss npm. Is it worth deleting tailwindcss from the config package and lose type safety for the config.ts file
There was a problem hiding this comment.
So we are adding in only the tailwindcss dependency for the config package
… dependencies setup(tailwind): bug fix in postcss setup(tailwind): fix pnpm lock file removed unused dependencies
… ui package
Summary
Made UI library a hub of any UI related things by all tailwind configs and css file required, an export by the ui library<
Also configured tailwind to the apps with the global config and is working
Depends on
No dependencies