-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GitHub and Google sign-in buttons #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidarth-23
requested review from
yogai53,
yaju09 and
elizabeththomas92
as code owners
March 20, 2024 13:27
sidarth-23
force-pushed
the
feat/github-and-google-signin-button
branch
from
March 21, 2024 16:28
e7211ba
to
58be733
Compare
yogai53
previously approved these changes
Mar 22, 2024
elizabeththomas92
requested changes
Mar 28, 2024
yaju09
requested changes
Mar 28, 2024
sidarth-23
force-pushed
the
feat/github-and-google-signin-button
branch
3 times, most recently
from
March 28, 2024 06:41
9e731b8
to
b16d56b
Compare
elizabeththomas92
previously approved these changes
Mar 28, 2024
sidarth-23
force-pushed
the
feat/github-and-google-signin-button
branch
from
March 28, 2024 08:51
b16d56b
to
b4ec87e
Compare
- Add GitHub sign-in button to allow users to sign in with GitHub. - Add Google sign-in button to allow users to sign in with Google. - These buttons will authenticate users and set cookies for access and refresh tokens. refactor: Fix import paths for actions and api-routes (#123) ✨ Add dynamic googleId reference in GoogleSignInButton ℹ️ Use dynamic googleId reference instead of hardcoding window.google.accounts.id in useState hooks and effects to improve code readability and maintainability. ✨ Fix useState initialization in GitHubSignInButton component ✨ Add error handling for Google Sign-in process Added comments to handle errors during Google Sign-in process for better error management and user experience. ✨ Add Google Sign-In button and configuration interfaces - Added new types for Google Sign-In button and Google Sign-In function. - Updated Google Sign-In button component to use the new interfaces. - Updated global window declaration for Google Sign-In functionality. ✨ Add type annotations for state variables in GitHubSignInButton component
sidarth-23
force-pushed
the
feat/github-and-google-signin-button
branch
from
March 28, 2024 08:58
b4ec87e
to
31632e2
Compare
yaju09
approved these changes
Mar 28, 2024
elizabeththomas92
approved these changes
Apr 8, 2024
yogai53
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshot
Depends on
#97