Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GitHub and Google sign-in buttons #95

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

sidarth-23
Copy link
Collaborator

@sidarth-23 sidarth-23 commented Mar 20, 2024

Summary

  • Add GitHub sign-in button to allow users to sign in with GitHub.
  • Add Google sign-in button to allow users to sign in with Google.
  • These buttons will authenticate users and set cookies for access and refresh tokens.
  • Added new types for Google Sign-In button and Google Sign-In function.
  • Updated Google Sign-In button component to use the new interfaces.
  • Updated global window declaration for Google Sign-In functionality.
  • Tested (Must)
  • Test Case added
  • Build Successful (Must)
  • Sufficient Code comments added (Must)
  • Attached Screenshots / Videos
  • All Relevant Documents added

Screenshot

image

Depends on

#97

@sidarth-23 sidarth-23 marked this pull request as draft March 20, 2024 13:44
@sidarth-23 sidarth-23 marked this pull request as ready for review March 21, 2024 14:32
@sidarth-23 sidarth-23 marked this pull request as draft March 21, 2024 14:53
@sidarth-23 sidarth-23 force-pushed the feat/github-and-google-signin-button branch from e7211ba to 58be733 Compare March 21, 2024 16:28
yogai53
yogai53 previously approved these changes Mar 22, 2024
@sidarth-23 sidarth-23 marked this pull request as ready for review March 22, 2024 08:51
apps/admin/components/github-signin.tsx Outdated Show resolved Hide resolved
apps/admin/components/github-signin.tsx Outdated Show resolved Hide resolved
apps/admin/components/github-signin.tsx Outdated Show resolved Hide resolved
apps/admin/components/google-signin.tsx Outdated Show resolved Hide resolved
apps/admin/components/google-signin.tsx Outdated Show resolved Hide resolved
apps/admin/components/google-signin.tsx Outdated Show resolved Hide resolved
@sidarth-23 sidarth-23 force-pushed the feat/github-and-google-signin-button branch 3 times, most recently from 9e731b8 to b16d56b Compare March 28, 2024 06:41
- Add GitHub sign-in button to allow users to sign in with GitHub.
- Add Google sign-in button to allow users to sign in with Google.
- These buttons will authenticate users and set cookies for access and refresh tokens.
refactor: Fix import paths for actions and api-routes (#123)
✨ Add dynamic googleId reference in GoogleSignInButton

ℹ️ Use dynamic googleId reference instead of hardcoding window.google.accounts.id in useState hooks and effects to improve code readability and maintainability.
✨ Fix useState initialization in GitHubSignInButton component
✨ Add error handling for Google Sign-in process

Added comments to handle errors during Google Sign-in process for better
error management and user experience.
✨ Add Google Sign-In button and configuration interfaces

- Added new types for Google Sign-In button and Google Sign-In function.
- Updated Google Sign-In button component to use the new interfaces.
- Updated global window declaration for Google Sign-In functionality.
✨ Add type annotations for state variables in GitHubSignInButton component
@sidarth-23 sidarth-23 force-pushed the feat/github-and-google-signin-button branch from b4ec87e to 31632e2 Compare March 28, 2024 08:58
@sidarth-23 sidarth-23 merged commit 1e9ae2b into master Apr 9, 2024
4 checks passed
@sidarth-23 sidarth-23 deleted the feat/github-and-google-signin-button branch April 9, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants