Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improve board type detection for ESP32 #266

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

kamaradclimber
Copy link
Owner

This will help cases where heishamon < 3.9 is running

This will help cases where heishamon < 3.9 is running
@kamaradclimber kamaradclimber merged commit 4807f8e into main Jan 2, 2025
2 checks passed
@IgorYbema
Copy link

It didn't detect it on my heishamon large just now. Says board type esp8266 instead of esp32 while it has 3.3v and more than 65535 heap. In some languages you need to compare a float to another float so it should be changed to > 65535.0
Maybe here also?

@IgorYbema
Copy link

Also it should be a float anyway. Should be a (large) int

@kamaradclimber
Copy link
Owner Author

Could you send me the stats mqtt message please?

@IgorYbema
Copy link

IgorYbema commented Jan 4, 2025

{
  "uptime": 2234058938,
  "voltage": 3.3,
  "free memory": 69,
  "free heap": 244028,
  "wifi": 82,
  "mqtt reconnects": 46,
  "total reads": 450367,
  "good reads": 450367,
  "bad crc reads": 0,
  "bad header reads": 0,
  "too short reads": 0,
  "too long reads": 0,
  "timeout reads": 0,
  "version": "3.9b",
  "rules active": 0
}

@kamaradclimber
Copy link
Owner Author

Thanks! will be fixed in 1.14.2. I made indeed a small mistake in type comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants