This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
new: Add FogColor #2152
Open
new: Add FogColor #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if I should use the ColorHolder, I didn't want to use it due to the Alpha slider not being used. |
|
I believe that you can make a colour setting with alpha disabled. Or if not it can probably just get ignored. |
Yes, It can be ignored. I am unsure if it can be removed from the GUI element, but if it can, I will gladly shift it to ColorHolder. Or if requested anyway, of course. |
|
you can use |
I'll look into it, may just make the other two and see what liv thinks is the best option |
5HT2
suggested changes
Mar 24, 2021
scorbett123
reviewed
Mar 24, 2021
src/main/kotlin/org/kamiblue/client/module/modules/render/FogColor.kt
Outdated
Show resolved
Hide resolved
5HT2
reviewed
Mar 24, 2021
5HT2
added
--review-pending
5HT2
approved these changes
Mar 25, 2021
5HT2
suggested changes
Mar 25, 2021
src/main/kotlin/org/kamiblue/client/module/modules/render/FogColor.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/kamiblue/client/module/modules/render/FogColor.kt
Outdated
Show resolved
Hide resolved
5HT2
approved these changes
Mar 25, 2021
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
Adds FogColor, a module to change the color of the render fog.
Describe how this pull is helpful
Closes #1120, and looks badass