New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow signing a JWS without adding a KID #23

Merged

Firstyear merged 1 commit into kanidm:main from Jeidnx:main

Feb 14, 2024

Contributor

Jeidnx commented Feb 9, 2024

Implements a new function on the JwsSigner trait and some changes to the trait implementors.

closes #19

cargo fmt has been run
cargo test has been run and passes
documentation has been updated with relevant examples (if relevant)


          feat: allow signing without kid

cf7b821

Added an option to all implementors of JwsSigner to disable adding the KID in the JWS header

Firstyear approved these changes

View reviewed changes

Member

Firstyear commented Feb 13, 2024

Thank you, I think this is a good change. Can you add yourself to contributors.md too?

Firstyear merged commit c40b7e7 into kanidm:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet