Update API surface to support Kanidm KeyObjects #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates a large amount of the API surface to support Kanidm key objects. This also changes the way we created the key id to make it more reliable to derive for verifiers.
|
Will you be updating the hsm-crypto version in a different MR? |
Good point, updated it here. |
yaleman
approved these changes
Apr 10, 2024
dmulder
reviewed
Apr 10, 2024
| @@ -46,7 +54,7 @@ impl JwsBuilder { | |||
| self | |||
| } | |||
|
|
|||
| /// Set the kid | |||
| #[cfg(test)] | |||
There was a problem hiding this comment.
This was here for a reason. MS requires a very specific header when sending a Windows Hello assertion.
There was a problem hiding this comment.
Yep, that was my mistake :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a large amount of the API surface to support Kanidm key objects. This also changes the way we created the key id to make it more reliable to derive for verifiers.