20231019 id key #13
Merged
20231019 id key #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstyear
force-pushed
the
20231019-id-key
branch
from
4017b7c to
ff057b1
Compare
Firstyear
commented
Oct 20, 2023
yaleman
approved these changes
Oct 20, 2023
dmulder
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second stage of the id key/cert pr. This adds the support to create a CSR, and to import the created x509 cert. Note the CSR is very limited in what it allows to be put into the request, because most machine identity certs overwrite the values of the CSR.
Checklist