Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on nightly, broken doc links #426

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

micolous
Copy link
Collaborator

@micolous micolous commented Apr 7, 2024

  • Updates actix_web and once_cell to pick up ahash>=0.8.7 (New Release tkaitchuck/aHash#188), as older versions are broken on nightly.
  • Removes redundant imports, which are now an error on nightly.
  • Expose optional features / types with any(all(doc, not(doctest)), feature(...)) so that documentation links always work.
  • cargo test has been run and passes
  • documentation has been updated with relevant examples (if relevant)

@micolous micolous mentioned this pull request Apr 7, 2024
2 tasks
@Firstyear Firstyear merged commit a506d89 into kanidm:master Apr 7, 2024
31 of 33 checks passed
kikuomax pushed a commit to codemonger-io/webauthn-rs that referenced this pull request Nov 24, 2024
* Update actix_web and once_cell to pick up ahash>=0.8.7 (tkaitchuck/aHash#188)

* Remove redundant imports, which are an error on rust nightly

* Expose optional features with `any(all(doc, not(doctest)), feature(...))'.

This fixes broken documentation links, and gives nice banners when building
docs on nightly (which docs.rs does).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants