add Get command to Kanx #3313
Open
add Get command to Kanx #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Alpar <[email protected]>
aaron-kasten
force-pushed
the
kanx-2-kubexec-A
branch
from
df71962 to
71c919a
Compare
tdmanv
reviewed
Jan 7, 2025
| @@ -1,7 +1,7 @@ | |||
| // Code generated by protoc-gen-go-grpc. DO NOT EDIT. | |||
| // versions: | |||
| // - protoc-gen-go-grpc v1.2.0 | |||
| // - protoc v3.12.4 | |||
| // - protoc-gen-go-grpc v1.5.1 | |||
There was a problem hiding this comment.
Thank you for upgrading this.
| rpc ListProcesses (ListProcessesRequest) returns (stream Process) {} | ||
| rpc Stdout (ProcessOutputRequest) returns (stream Output) {} | ||
| rpc Stderr (ProcessOutputRequest) returns (stream Output) {} | ||
| rpc Stdout (ProcessPidRequest) returns (stream Output) {} |
There was a problem hiding this comment.
Could you please clarify this Change?
There was a problem hiding this comment.
@tdmanv Ah. There are RPC requests in the protocol that take only one argument, the PID. I've simplified these RPC requests by consolidating the Process*Request to ProcessPidRequest
It leads to a smaller kanx.proto file, and personally, I think its clearer.
Footnote: it doesn't look like GRPC uses the *Request structure to qualify the call.
tdmanv
approved these changes
Jan 8, 2025
| rpc ListProcesses (ListProcessesRequest) returns (stream Process) {} | ||
| rpc Stdout (ProcessOutputRequest) returns (stream Output) {} | ||
| rpc Stderr (ProcessOutputRequest) returns (stream Output) {} | ||
| rpc Stdout (ProcessPidRequest) returns (stream Output) {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Add
GetProcessto kanx client/server.GetProcessallows retrieval of a single process by PID, instead of only being able to retrieve process information in lists. Implementing this protocol allows for simplifying some code as well as decoupling process summary information provided byListProcessesand process detail information provided byGetProcess.This PR also includes some trivial changes for clarity.
Pull request type
Please check the type of change your PR introduces:
Issues
This is not related to a Github issue.
Test Plan
Unit test included, plus existing unit tests have been converted from
ListProcessestoGetProcess