fix: H: fixup command line usage and grpc log level setting. #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Alpar <[email protected]>
Signed-off-by: Aaron Alpar <[email protected]>
Signed-off-by: Aaron Alpar <[email protected]>
Signed-off-by: Aaron Alpar <[email protected]>
Signed-off-by: Aaron Alpar <[email protected]>
Signed-off-by: Aaron Alpar <[email protected]>
Signed-off-by: Aaron Alpar <[email protected]>
Signed-off-by: Aaron Alpar <[email protected]>
Signed-off-by: Aaron Alpar <[email protected]>
…into kanx-2-kubexec-G
…nto kanx-2-kubexec-H
aaron-kasten
requested review from
tdmanv,
hairyhum,
Shrekster and
redgoat650
…nto kanx-2-kubexec-H
…nto kanx-2-kubexec-H
tdmanv
approved these changes
Jan 18, 2025
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR fixes a mistake in the
ProcessClientSignalcommand-line documentation and passes command-line logging parameters to GRPC logging subsystem. Setting GRPC log level helps control verbosity of command output, simplifying use and debugging.Pull request type
Please check the type of change your PR introduces:
Issues
There is no GitHub issue associated with this PR
Test Plan
GRPC output is library dependent. Will need to test log level settings manually.