Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ember upgrade attempt v5.3 #2256

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Feature/ember upgrade attempt v5.3 #2256

merged 6 commits into from
Nov 28, 2024

Conversation

ValenberghsSven
Copy link
Contributor

@ValenberghsSven ValenberghsSven commented Nov 26, 2024 •
edited
Loading

https://kanselarij.atlassian.net/browse/KAS-4922

from v5.0 to v5.3

Fixed a few deprecations now that would be an issue in v6:

  • Using ember-inflector like we were doing is deprecated, change to ember internal package
  • We had an incorrect type in model hasMany('themes') instead of hasMany('theme') . Model itself is called Theme
  • Got a deprecation warning that required us to manually create a transform for number, string and boolean (with import as default). So I did.
    image

Base automatically changed from feature/ember-upgrade-attempt to development November 28, 2024 15:33
@ValenberghsSven ValenberghsSven marked this pull request as ready for review November 28, 2024 15:33
@ValenberghsSven
Copy link
Contributor Author

No major breaking tests, only known flakys

@ValenberghsSven ValenberghsSven merged commit 25d9ca1 into development Nov 28, 2024
2 of 4 checks passed
@ValenberghsSven ValenberghsSven deleted the feature/ember-upgrade-attempt-v5.3 branch November 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ValenberghsSven