KAS-4805 implement emptying interal review private comment feature

app/components/agenda/agenda-header/agenda-actions.hbs

@@ -115,6 +115,15 @@
       {{t "approve-all-agendaitems"}}
     </AuButton>
   {{/if}}
+  {{#if this.canEmptyInternalReviews}}
+    <AuButton
+      @skin="link"
+      {{on "click" this.openConfirmEmptyInternalReviews}}
+      role="menuitem"
+    >
+      {{t "empty-internal-review"}}
+    </AuButton>
+  {{/if}}
   {{#if this.canPublishDecisions}}
     <AuHr />
     <AuButton
@@ -348,3 +357,24 @@
     </div>
   </:body>
 </ConfirmationModal>
+
+{{#if this.showConfirmEmptyInternalReviews}}
+  <Auk::Modal @size="small">
+    <Auk::Modal::Header
+      @title={{t "empty-internal-review"}}
+      @onClose={{this.cancelEmptyInternalReviews}}
+    />
+    <Auk::Modal::Body>
+      <p class="auk-u-text-prewrap">{{t "empty-internal-review-message"}}</p>
+    </Auk::Modal::Body>
+    <Auk::Modal::Footer @onCancel={{this.cancelEmptyInternalReviews}}>
+      <AuButton
+        @skin="primary"
+        @loading={{this.emptyInteralReviewsOfAgendaitemThrottled.isRunning}}
+        {{on "click" this.emptyInteralReviews}}
+      >
+        {{t "empty-internal-review"}}
+      </AuButton>
+    </Auk::Modal::Footer>
+  </Auk::Modal>
+{{/if}}

app/components/agenda/agenda-header/agenda-actions.js

@@ -12,7 +12,7 @@ import {
 } from 'frontend-kaleidos/utils/zip-agenda-files';
 import CONSTANTS from 'frontend-kaleidos/config/constants';
 import bind from 'frontend-kaleidos/utils/bind';
-import { isPresent } from '@ember/utils';
+import { isEmpty, isPresent } from '@ember/utils';
 import DownloadFileToast from 'frontend-kaleidos/components/utils/toaster/download-file-toast';
 
 /**
@@ -53,6 +53,7 @@ export default class AgendaAgendaHeaderAgendaActions extends Component {
   @tracked showDownloadDocuments = false;
   @tracked selectedMandatees = [];
   @tracked showDownloadDecisions = false;
+  @tracked showConfirmEmptyInternalReviews = false;
 
   @tracked decisionPublicationActivity;
   @tracked documentPublicationActivity;
@@ -352,6 +353,43 @@ export default class AgendaAgendaHeaderAgendaActions extends Component {
     this.router.refresh(this.router.currentRouteName);
   }
 
+  get canEmptyInternalReviews() {
+    // action will do nothing on designAgenda A, so hide it instead
+    const isDesignAgendaA = this.args.currentAgenda.status.get('isDesignAgenda') && this.args.currentAgenda.serialnumber === 'A';
+    return this.currentSession.may('manage-agendaitems') && !isDesignAgendaA;
+  }
+
+  emptyInteralReviews = async() => {
+    this.showConfirmEmptyInternalReviews = false;
+    this.args.onStartLoading(this.intl.t('empty-internal-review'));
+    // getting all valid agendaitems first gets better results than trying submission-internal-review directly via subcase
+    const approvedAgendaitems = await this.store.queryAll('agendaitem', {
+      'filter[:has:previous-version]': true,
+      'filter[agenda][:id:]': this.args.currentAgenda.id,
+    });
+    const savePromises = approvedAgendaitems.map((internalReview) => this.emptyInteralReviewsOfAgendaitemThrottled.perform(internalReview));
+    await all(savePromises);
+    // TODO KAS-4886 this can go when we no longer have to save agendaitems
+    this.args.onStopLoading();
+    this.args.didApproveAgendaitems();
+  };
+
+  emptyInteralReviewsOfAgendaitemThrottled = task({ maxConcurrency: 5}, async (agendaitem) => {
+    const internalReview = await this.store.queryOne('submission-internal-review', {
+      'filter[subcase][agenda-activities][agendaitems][:id:]': agendaitem.id,
+    })
+    if (internalReview?.id && !isEmpty(internalReview.privateComment)) {
+      internalReview.privateComment = '';
+      return await internalReview.save();
+    }
+    // This property is still filled in as of now, we should empty it to avoid showing this briefly in agenda overview
+    // TODO KAS-4886 remove when property is removed from model
+    if (!isEmpty(agendaitem.privateComment)) {
+      agendaitem.privateComment = '';
+      return await agendaitem.save();
+    }
+  });
+
   @action
   print() {
     window.print();
@@ -463,4 +501,14 @@ export default class AgendaAgendaHeaderAgendaActions extends Component {
   onChangeDownloadOption(selectedDownloadOption) {
     this.downloadOption = selectedDownloadOption;
   }
+
+  openConfirmEmptyInternalReviews = () => {
+  // TODO KAS-4886 this first line can go when we no longer have to save agendaitems
+  this.reloadAgendaitemsData.perform(); // Do we need to reload anything?? The interalreview may not be loaded yet, but the model itself cannot be stale
+  this.showConfirmEmptyInternalReviews = true;
+  };
+
+  cancelEmptyInternalReviews = () => {
+    this.showConfirmEmptyInternalReviews = false;
+  };
 }

app/controllers/newsletters/index.js

@@ -38,7 +38,7 @@ export default class NewslettersIndexController extends Controller {
     const agendas = await meeting.agendas;
     return agendas
       ?.slice()
-      .sort((a1, a2) => a1.serialNumber.localeCompare(a2.serialNumber))
+      .sort((a1, a2) => a1.serialnumber.localeCompare(a2.serialnumber))
       .reverse()
       .at(0);
   }

translations/nl-be.json

@@ -1485,5 +1485,7 @@
   "press-agenda": "Persagenda",
   "generate-press-agenda": "Genereer persagenda",
   "login-text" : "Meld u aan",
-  "show-definitive-cases-only": "Toon enkel dossiers zonder definitieve goedkeuring"
+  "show-definitive-cases-only": "Toon enkel dossiers zonder definitieve goedkeuring",
+  "empty-internal-review": "Interne opmerkingen leegmaken",
+  "empty-internal-review-message": "Bent u zeker dat u alle interne opmerkingen voor de goedgekeurde agendapunten op deze agenda wil leegmaken?\nDeze actie kan niet ongedaan worden gemaakt.\nDe interne opmerkingen van nieuwe agendapunten blijven ongewijzigd."
 }