Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAS-4890: Uitgestelde punten heragenderen met indieningen #2268

Open
wants to merge 11 commits into
base: development
Choose a base branch
from

Conversation

sergiofenoll
Copy link
Member

@sergiofenoll sergiofenoll commented Dec 6, 2024

@sergiofenoll sergiofenoll changed the base branch from development to acceptance December 6, 2024 11:43
@sergiofenoll
Copy link
Member Author

This branches off from ACC, but I accidentally set the base branch of the PR to DEV.

Copy link
Contributor

@ValenberghsSven ValenberghsSven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check branched PR,
Had some issues that I solved there.
Currently I was stuck on the following:
First submission > agenda 18/12, postponed
second submission > agenda 20/12, meeting could be selected.
BIS submission > originalSubmission is used to get the meeting, which gets 18/12
previousSubmission was the logical choice, but was null for some reason.
Going to look at this again tomorrow.

Any Fixes I do will be in the branched PR for clarity

app/utils/cabinet-submission-email.js Outdated Show resolved Hide resolved
app/services/draft-submission-service.js Show resolved Hide resolved
@ValenberghsSven ValenberghsSven changed the base branch from acceptance to development December 20, 2024 16:06
@ValenberghsSven
Copy link
Contributor

changed base to DEV, no more trying to rush this.

Copy link
Contributor

@ValenberghsSven ValenberghsSven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extremely biased review 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants