Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement mute command #151

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

01110111-wave
Copy link
Contributor

@01110111-wave 01110111-wave commented May 26, 2023

Description

Implement muting system which introduce severe mute punishment and auto server unmuting. Auto unmuting work when user use slash command /appeal-for-server-mute ; this will unmute every user that is in voice channel and is not under severe mute punishment. Severe mute punishment is a mute punishment that can be used by mod as a heavier punishment, to be pardoned the offender must appeal a moderator directly and make an apology message that moderator accept to use message command Severe mute pardon on to pardon the user and unmute user. As you might concern about wrong punishment, I have created a slash command /severe-mute-pardon to lift punishment when penalty was falsefully apply.

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshot

image

Checklist:

  • I have run pnpm format and my code don't have any linting issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Collaborator

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution.

i really appreciate your effort in implementing this, however, i haven't heard from any moderator who is having hassle in un-muting a user. the #ขอคืนไมค์ channel current has about 1 request per day.

still, i see the benefit of a member being able to un-server-mute themselves without having to bother a moderator. on the other hand, this also incurs some learning curve by the moderator as it introduces one more moving part.

from ux perspective, the word "severe" and "server" is so similar. even i am confused.

let’s hear from moderators. cc @quarkhadron @LagSeeN. what do you think about this feature?

) {
try {
//muting might fail if the target is in higher role hierachy.
await member.voice.setMute(true, 'Severe mute from breaking server rules.') // imply that severe mute will be use only when user break server rule.
Copy link
Collaborator

@dtinth dtinth May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if user already left the voice channel when a mod decides to severe mute? it won’t crash, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it won't crash the bot.

@01110111-wave 01110111-wave marked this pull request as draft May 26, 2023 14:15
@01110111-wave
Copy link
Contributor Author

About mod hassle, it is not only the mod hassle, but for ease of member to regain their talkability without having to wait. Regarding UX, I will change the name based on moderator wish.

PS. I will leave it as draft until mod deem this feature is mandatory, and also thank for your hard work and effort to bear with my crappy code.

@LagSeeN
Copy link
Collaborator

LagSeeN commented May 26, 2023

thanks you but very few or none of them were server muted. in #ขอคืนไมค์ channel very few cases were asked to unmute. Most of them are emoji spam 🫠. anyway let's try hear from other people. 🙇‍♂️🙇‍♂️🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants