Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop scrolling when switching between windows #100

Closed
wants to merge 1 commit into from

Conversation

vilari-mickopf
Copy link

Fix #99

active_scroll.winid was present but not used, so i've used it to set current win id in before_scrolling function, and then check if window is changed in scroll_callback function.

@karb94
Copy link
Owner

karb94 commented Apr 27, 2024

Thank you for reporting #99. The active_scroll.winid is there because I am working on adding functionality to scroll windows other than the active window (one application of this is #79). This will also prevent #99 from occurring because the scroll will be tied to the winid. I will close this as I think users are not severely impacted by #99 and can wait a little bit longer.

@karb94 karb94 closed this Apr 27, 2024
@vilari-mickopf
Copy link
Author

Understandable, it was just annoying and looked like an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animation continues in new window after switching during animation
2 participants