Fishhash plus implementation with hard fork procedure #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HF defined at DAA score 6,000,000 HF date will be calculated in a future commit
wam-rd
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
ok
tested locally with success with algo switch on block 50
tested on testnet-1 with success.
I will test the sync form 1 node to another freshly hard forked, to validate the block header validation algo switch.
I approve this PR and will continue my testings
lemois-1337
reviewed
Mar 20, 2024
Comment on lines
+62
to
+67
| /* | ||
| if header.Version() != constants.BlockVersion { | ||
| return errors.Wrapf( | ||
| ruleerrors.ErrWrongBlockVersion, "The block version should be %d", constants.BlockVersion) | ||
| } | ||
| */ |
There was a problem hiding this comment.
Is there a reason why this is commented? Explicit error in case an old node would send a wrong version block after hardfork is needed.
There was a problem hiding this comment.
It has been replaced by a conditional check on BlockVersionAfterHF BlockVersionBeforeHF to reject block with bad version after or before HF
|
I will merge it, we will define HF date later and define DAA score. |
lemois-1337
merged commit 1b6644b
into
karlsen-network:2024_testnet_1_fishhashplus
0 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HF defined at DAA score 6,000,000
HF date will be calculated in a future commit