Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let rb status controller onCreate predicate return true #5865

Merged
merged 1 commit into from
Nov 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/controllers/status/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,13 @@ import (
)

var bindingPredicateFn = builder.WithPredicates(predicate.Funcs{
CreateFunc: func(event.CreateEvent) bool { return false },
CreateFunc: func(event.CreateEvent) bool {
// Although we don't need to process the ResourceBinding immediately upon its creation,
// but it's necessary to ensure that all existing ResourceBindings are processed
// uniformly once when the component restarts.
// This guarantees that no ResourceBinding is missed after a controller restart.
return true
},
UpdateFunc: func(e event.UpdateEvent) bool {
var oldResourceVersion, newResourceVersion string

Expand Down