Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5865: let rb status controller onCreate predicate return true #5883

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Nov 26, 2024

Cherry pick of #5865 on release-1.10.
#5865: let rb status controller onCreate predicate return true
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed the corner case where the reconciliation of aggregating status might be missed in case of component restart.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 51.47%. Comparing base (b00a7df) to head (981d8b2).

Files with missing lines Patch % Lines
pkg/controllers/status/common.go 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #5883      +/-   ##
================================================
- Coverage         51.52%   51.47%   -0.05%     
================================================
  Files               260      260              
  Lines             25776    25782       +6     
================================================
- Hits              13280    13272       -8     
- Misses            11761    11773      +12     
- Partials            735      737       +2     
Flag Coverage Δ
unittests 51.47% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@karmada-bot karmada-bot merged commit 7356ffe into karmada-io:release-1.10 Nov 27, 2024
12 checks passed
@liangyuanpeng liangyuanpeng deleted the automated-cherry-pick-of-#5865-upstream-release-1.10 branch November 27, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants