-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace instruction annotation with work suspendDispatching field #6043
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: vie-serendipity <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6043 +/- ##
==========================================
- Coverage 48.35% 48.33% -0.02%
==========================================
Files 666 668 +2
Lines 54831 54854 +23
==========================================
+ Hits 26513 26516 +3
- Misses 26599 26617 +18
- Partials 1719 1721 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: vie-serendipity <[email protected]>
982414c
to
2f2ae0a
Compare
Signed-off-by: vie-serendipity <[email protected]>
/retest |
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
Replace
propagation.karmada.io/instruction
withsuspendDispatching
field. Annotation was just a temporary solution. With the native support of the work API, we should deprecate the use of annotations and utilize the work field instead.Which issue(s) this PR fixes:
Fixes #5386
Special notes for your reviewer:
Does this PR introduce a user-facing change?: