Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace instruction annotation with work suspendDispatching field #6043

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vie-serendipity
Copy link
Contributor

What type of PR is this?

/kind deprecation
What this PR does / why we need it:
Replace propagation.karmada.io/instruction with suspendDispatching field. Annotation was just a temporary solution. With the native support of the work API, we should deprecate the use of annotations and utilize the work field instead.
Which issue(s) this PR fixes:
Fixes #5386

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Users who are still using annotations to suspend work should migrate to the `suspendDispatching` field as soon as possible.

@karmada-bot karmada-bot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Jan 14, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign whitewindmills for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 2.63158% with 37 lines in your changes missing coverage. Please review.

Project coverage is 48.33%. Comparing base (446dbe9) to head (424225b).

Files with missing lines Patch % Lines
pkg/controllers/mcs/common.go 0.00% 10 Missing ⚠️
pkg/controllers/mcs/service_export_controller.go 0.00% 9 Missing ⚠️
pkg/util/helper/predicate.go 0.00% 6 Missing and 2 partials ⚠️
cmd/agent/app/agent.go 0.00% 3 Missing ⚠️
cmd/controller-manager/app/controllermanager.go 0.00% 3 Missing ⚠️
pkg/util/work.go 0.00% 2 Missing ⚠️
...clusterservice/endpointslice_collect_controller.go 50.00% 1 Missing ⚠️
.../controllers/multiclusterservice/mcs_controller.go 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6043      +/-   ##
==========================================
- Coverage   48.35%   48.33%   -0.02%     
==========================================
  Files         666      668       +2     
  Lines       54831    54854      +23     
==========================================
+ Hits        26513    26516       +3     
- Misses      26599    26617      +18     
- Partials     1719     1721       +2     
Flag Coverage Δ
unittests 48.33% <2.63%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace work propagation.karmada.io/instruction annotation with work Suspension field
4 participants