Clippy

crates/kas-core/Cargo.toml

@@ -134,3 +134,8 @@ version = "0.30.1"
 optional = true
 default-features = false
 features = ["rwh_06"]
+
+[lints.clippy]
+module_inception = "allow"
+needless_lifetimes = "allow"
+unit_arg = "allow"

crates/kas-core/src/event/cx/mod.rs

@@ -84,19 +84,16 @@ struct MouseGrab {
 impl<'a> EventCx<'a> {
     fn flush_mouse_grab_motion(&mut self) {
         if let Some(grab) = self.mouse_grab.as_mut() {
-            match grab.details {
-                GrabDetails::Click { ref cur_id } => {
-                    if grab.start_id == cur_id {
-                        if grab.depress != *cur_id {
-                            grab.depress = cur_id.clone();
-                            self.action |= Action::REDRAW;
-                        }
-                    } else if grab.depress.is_some() {
-                        grab.depress = None;
+            if let GrabDetails::Click { ref cur_id } = grab.details {
+                if grab.start_id == cur_id {
+                    if grab.depress != *cur_id {
+                        grab.depress = cur_id.clone();
                         self.action |= Action::REDRAW;
                     }
+                } else if grab.depress.is_some() {
+                    grab.depress = None;
+                    self.action |= Action::REDRAW;
                 }
-                _ => (),
             }
         }
     }

crates/kas-core/src/event/cx/platform.rs

@@ -371,14 +371,13 @@ impl<'a> EventCx<'a> {
                     // TODO(winit): https://github.com/rust-windowing/winit/issues/3038
                     let mut mods = self.modifiers;
                     mods.remove(ModifiersState::SHIFT);
-                    if !mods.is_empty() {
-                        event.text = None;
-                    } else if event
-                        .text
-                        .as_ref()
-                        .and_then(|t| t.chars().next())
-                        .map(|c| c.is_control())
-                        .unwrap_or(false)
+                    if !mods.is_empty()
+                        || event
+                            .text
+                            .as_ref()
+                            .and_then(|t| t.chars().next())
+                            .map(|c| c.is_control())
+                            .unwrap_or(false)
                     {
                         event.text = None;
                     }

crates/kas-macros/Cargo.toml

@@ -39,3 +39,7 @@ features = ["extra-traits", "full", "visit", "visit-mut"]
 
 [build-dependencies]
 version_check = "0.9"
+
+[lints.clippy]
+collapsible_else_if = "allow"
+unit_arg = "allow"

crates/kas-view/Cargo.toml

@@ -23,3 +23,8 @@ linear-map = "1.2.0"
 
 # We must rename this package since macros expect kas to be in scope:
 kas = { version = "0.14.1", package = "kas-core", path = "../kas-core" }
+
+[lints.clippy]
+collapsible_else_if = "allow"
+needless_lifetimes = "allow"
+unit_arg = "allow"

crates/kas-wgpu/Cargo.toml

@@ -53,3 +53,7 @@ features = ["spirv"]
 
 [build-dependencies]
 glob = "0.3"
+
+[lints.clippy]
+needless_lifetimes = "allow"
+unit_arg = "allow"

crates/kas-widgets/Cargo.toml

@@ -31,3 +31,12 @@ linear-map = "1.2.0"
 
 # We must rename this package since macros expect kas to be in scope:
 kas = { version = "0.14.1", package = "kas-core", path = "../kas-core" }
+
+[lints.clippy]
+collapsible_else_if = "allow"
+collapsible_if = "allow"
+comparison_chain = "allow"
+module_inception = "allow"
+needless_lifetimes = "allow"
+redundant_pattern_matching = "allow"
+unit_arg = "allow"

crates/kas-widgets/src/spinner.rs

@@ -67,6 +67,7 @@ macro_rules! impl_int {
                 ((self / step).saturating_add(1)).saturating_mul(step).min(u_bound)
             }
             fn sub_step(self, step: Self, l_bound: Self) -> Self {
+                #[allow(clippy::manual_div_ceil)] // only stable on a subset of types used
                 (((self + step - 1) / step).saturating_sub(1)).saturating_mul(step).max(l_bound)
             }
         }