-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create TN11 KIP10 HF activation and KIP9 beta switch #595
base: master
Are you sure you want to change the base?
Conversation
There is a remaining issue related to the sync gap between mempool state and virtual/block template state. Currently we set the tx mass (https://github.com/kaspanet/rusty-kaspa/blob/master/consensus/src/pipeline/virtual_processor/utxo_validation.rs#L343) when the transaction enters the mempool (which will be based on virtual daa score at the time), however when the transaction enters the block template, virtual might have already progressed ahead, reaching the hf activation, so the mass will contain the wrong commitment. One obvious solution is to recalc the mass according to the final pov daa score at Another option is to ignore the whole thing and to rely on |
05f5ade
to
12b8558
Compare
12b8558
to
fddda54
Compare
Change
Notes
Kip9Version::Beta
for both mempool and consensus (if activated there). Perhaps a cleanup of KIP9 logic, removing all references to Alpha, is in order after said HF.