IBD sync: recover sampled window #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsutton
force-pushed
the
ibd-cover-sampled-window
branch
from
072bac7
to
f76c71c
Compare
…avoid leaking logic out of the TransactionValidator)
someone235
requested changes
Nov 24, 2024
consensus/src/processes/transaction_validator/tx_validation_in_header_context.rs
Outdated
Show resolved
Hide resolved
D-Stacks
reviewed
Nov 25, 2024
consensus/src/processes/transaction_validator/tx_validation_in_header_context.rs
Show resolved
Hide resolved
coderofstuff
previously approved these changes
Nov 26, 2024
There was a problem hiding this comment.
I'm approving this based on my read that each commit here accomplishes the intended change of:
- ensuring cache reader can only get a window if the window's origin matches the reader's
- the locktime logic doesn't leak outside of the locktime checks
- documentation and refactors/rename
…t of an existing thread pool (avoid creating a global thread pool if possible)
coderofstuff
approved these changes
Nov 28, 2024
someone235
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a rare bug in TN11 where the syncer does not send sufficient DAA window blocks required for recovering the sampled DAA window.
The sampling mechanism relies on DAA indexes which can only be calculated correctly if the full mergesets covering all sampled blocks are sent.
Note: fixes a (future) bug from the recent PR where cache entries were not filtered by origin. See commit.
Edit: added also a refactor to tx time lock validation and some long due renames for various tx validation modules