Make active_job-performs an optional dependency #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To update and get the same behavior, you must explicitly put `active_job-performs` in your Gemfile: ```ruby gem "active_job-performs" gem "active_record-associated_object" ``` Also, I'm wrapping the integrations in a `config.after_initialize` so gem order in the Gemfile shouldn't matter. E.g. if you put kredis after associated_object we should still be able to connect.
kaspth
force-pushed
the
optional-performs-dependency
branch
from
8595cf5 to
76631ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To update and get the same behavior, you must explicitly put
active_job-performsin your Gemfile:Also, I'm wrapping the integrations in a
config.after_initializeso gem order in the Gemfile shouldn't matter. E.g. if you put kredis after associated_object we should still be able to connect.