Support Polymorphic Associated Objects: Take 2 #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #25, we discussed how to have Polymorphic Associated Objects and we ultimately ruled that it was better to share code via concerns.
I tried a slightly alternate approach, but I'm still coming to the same conclusion: trying to remove/defer the connection to an Active Record class opens up a whole bunch of complexity. E.g.
extension
blocks needs to be captured and then applied when the actual connection happens.So I'm opening this just for reference and I'm closing it immediately in favor of writing up the concerns approach.