Fix ActiveJob::Performs not being automatically extended #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooops, we need to work with #14 too. |
`ActiveSupport.on_load :active_job` may not fire after the application has loaded (since it happens when Active Job is first mentioned and then it's loaded), which means any Associated Objects loaded would not have `performs` defined and we'd raise. The short curcuit was to only inject performs if users were using Active Job, but it's too clever.
kaspth
force-pushed
the
fix-performs-integration-in-railtie
branch
from
58643ed to
0929279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveSupport.on_load :active_jobmay not fire after the application has loaded (since it happens when Active Job is first mentioned and then it's loaded), which means any Associated Objects loaded would not haveperformsdefined and we'd raise.The short curcuit was to only inject performs if users were using Active Job, but it's too clever.
We're now being less clever and letting bundler load every gem first via deferring our extension to the others in
config.after_initialize.