This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
add resp3 protocol part 1(add data type and implement some simple) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chyroc
force-pushed
the
add-resp3-protocol-part-1
branch
from
acff465 to
5633281
Compare
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 72.18% 72.37% +0.18%
==========================================
Files 10 11 +1
Lines 640 742 +102
==========================================
+ Hits 462 537 +75
- Misses 171 187 +16
- Partials 7 18 +11
Continue to review full report at Codecov.
|
chyroc
force-pushed
the
add-resp3-protocol-part-1
branch
from
5633281 to
6da6733
Compare
kasvith
approved these changes
Aug 26, 2018
kasvith
reviewed
Aug 26, 2018
| type ErrProtocolType struct { | ||
| Type byte | ||
| } | ||
|
|
There was a problem hiding this comment.
If these errors should not disconnect client, you can implement Recoverable interface on them
chyroc
force-pushed
the
add-resp3-protocol-part-1
branch
from
6da6733 to
cc55216
Compare
|
Lint errors :) |
chyroc
force-pushed
the
add-resp3-protocol-part-1
branch
from
cc55216 to
e3e18d0
Compare
kasvith
approved these changes
Aug 27, 2018
|
Tnx @chyroc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for issue
#76
Description