Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the dependencies group with 11 updates #23

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Bump the dependencies group with 11 updates #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 39 additions & 39 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ GEM
erubi (~> 1.11)
rails-dom-testing (~> 2.2)
rails-html-sanitizer (~> 1.6)
active_storage_validations (1.1.3)
active_storage_validations (1.1.4)
activejob (>= 5.2.0)
activemodel (>= 5.2.0)
activestorage (>= 5.2.0)
Expand Down Expand Up @@ -89,7 +89,7 @@ GEM
minitest (>= 5.1)
mutex_m
tzinfo (~> 2.0)
addressable (2.8.5)
addressable (2.8.6)
public_suffix (>= 2.0.2, < 6.0)
ast (2.4.2)
base64 (0.2.0)
Expand All @@ -100,7 +100,7 @@ GEM
erubi (~> 1.4)
parser (>= 2.4)
smart_properties
bigdecimal (3.1.4)
bigdecimal (3.1.5)
builder (3.2.4)
capybara (3.39.2)
addressable
Expand Down Expand Up @@ -132,9 +132,9 @@ GEM
rubocop
smart_properties
erubi (1.12.0)
factory_bot (6.4.2)
factory_bot (6.4.5)
activesupport (>= 5.0.0)
factory_bot_rails (6.4.2)
factory_bot_rails (6.4.3)
factory_bot (~> 6.4)
railties (>= 5.0.0)
faker (3.2.2)
Expand All @@ -156,23 +156,23 @@ GEM
image_processing (1.12.2)
mini_magick (>= 4.9.5, < 5)
ruby-vips (>= 2.0.17, < 3)
importmap-rails (1.2.3)
importmap-rails (2.0.1)
actionpack (>= 6.0.0)
activesupport (>= 6.0.0)
railties (>= 6.0.0)
io-console (0.6.0)
irb (1.10.1)
io-console (0.7.1)
irb (1.11.0)
rdoc
reline (>= 0.3.8)
json (2.7.1)
katalyst-html-attributes (1.0.0)
katalyst-html-attributes (1.0.1)
activesupport
html-attributes-utils
katalyst-kpop (3.0.1)
katalyst-html-attributes
turbo-rails
view_component
katalyst-tables (2.2.12)
katalyst-tables (2.3.1)
katalyst-html-attributes
view_component
language_server-protocol (3.17.0.3)
Expand All @@ -191,33 +191,33 @@ GEM
mini_mime (1.1.5)
minitest (5.20.0)
mutex_m (0.2.0)
net-imap (0.4.7)
net-imap (0.4.9.1)
date
net-protocol
net-pop (0.1.2)
net-protocol
net-protocol (0.2.2)
timeout
net-smtp (0.4.0)
net-smtp (0.4.0.1)
net-protocol
nio4r (2.7.0)
nokogiri (1.15.5-arm64-darwin)
nokogiri (1.16.0-arm64-darwin)
racc (~> 1.4)
nokogiri (1.15.5-x86_64-linux)
nokogiri (1.16.0-x86_64-linux)
racc (~> 1.4)
parallel (1.23.0)
parser (3.2.2.4)
parallel (1.24.0)
parser (3.3.0.2)
ast (~> 2.4.1)
racc
propshaft (0.8.0)
actionpack (>= 7.0.0)
activesupport (>= 7.0.0)
rack
railties (>= 7.0.0)
psych (5.1.1.1)
psych (5.1.2)
stringio
public_suffix (5.0.4)
puma (6.4.0)
puma (6.4.1)
nio4r (~> 2.0)
racc (1.7.3)
rack (3.0.8)
Expand Down Expand Up @@ -263,10 +263,10 @@ GEM
zeitwerk (~> 2.6)
rainbow (3.1.1)
rake (13.1.0)
rdoc (6.6.1)
rdoc (6.6.2)
psych (>= 4.0.0)
regexp_parser (2.8.3)
reline (0.4.1)
regexp_parser (2.9.0)
reline (0.4.2)
io-console (~> 0.5)
rexml (3.2.6)
rspec-core (3.12.2)
Expand All @@ -286,7 +286,7 @@ GEM
rspec-mocks (~> 3.12)
rspec-support (~> 3.12)
rspec-support (3.12.1)
rubocop (1.58.0)
rubocop (1.59.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
Expand All @@ -299,44 +299,44 @@ GEM
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.30.0)
parser (>= 3.2.1.0)
rubocop-capybara (2.19.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
rubocop-factory_bot (2.24.0)
rubocop-factory_bot (2.25.0)
rubocop (~> 1.33)
rubocop-katalyst (1.1.4)
rubocop
rubocop-performance
rubocop-rails
rubocop-rake
rubocop-rspec
rubocop-performance (1.19.1)
rubocop (>= 1.7.0, < 2.0)
rubocop-ast (>= 0.4.0)
rubocop-rails (2.22.2)
rubocop-performance (1.20.1)
rubocop (>= 1.48.1, < 2.0)
rubocop-ast (>= 1.30.0, < 2.0)
rubocop-rails (2.23.1)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.33.0, < 2.0)
rubocop-ast (>= 1.30.0, < 2.0)
rubocop-rake (0.6.0)
rubocop (~> 1.0)
rubocop-rspec (2.25.0)
rubocop-rspec (2.26.1)
rubocop (~> 1.40)
rubocop-capybara (~> 2.17)
rubocop-factory_bot (~> 2.22)
ruby-progressbar (1.13.0)
ruby-vips (2.2.0)
ffi (~> 1.12)
ruby2_keywords (0.0.5)
sass-embedded (1.69.5-arm64-darwin)
google-protobuf (~> 3.23)
sass-embedded (1.69.5-x86_64-linux-gnu)
google-protobuf (~> 3.23)
shoulda-matchers (5.3.0)
sass-embedded (1.69.7-arm64-darwin)
google-protobuf (~> 3.25)
sass-embedded (1.69.7-x86_64-linux-gnu)
google-protobuf (~> 3.25)
shoulda-matchers (6.0.0)
activesupport (>= 5.2.0)
smart_properties (1.17.0)
sqlite3 (1.6.9-arm64-darwin)
sqlite3 (1.6.9-x86_64-linux)
stimulus-rails (1.3.0)
sqlite3 (1.7.0-arm64-darwin)
sqlite3 (1.7.0-x86_64-linux)
stimulus-rails (1.3.3)
railties (>= 6.0.0)
stringio (3.1.0)
thor (1.3.0)
Expand All @@ -348,7 +348,7 @@ GEM
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (2.5.0)
view_component (3.8.0)
view_component (3.9.0)
activesupport (>= 5.2.0, < 8.0)
concurrent-ruby (~> 1.0)
method_source (~> 1.0)
Expand Down Expand Up @@ -395,4 +395,4 @@ DEPENDENCIES
turbo-rails

BUNDLED WITH
2.4.22
2.5.4
2 changes: 1 addition & 1 deletion spec/models/katalyst/content/figure_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
figure.image = Rack::Test::UploadedFile.new(Rails.root.parent.join("fixtures/images/sample.png"), "image/png")
copy = figure.dup
copy.save!
expect(ActiveStorage::Blob.service).to be_exist(copy.image.blob.key)
expect(ActiveStorage::Blob.service).to exist(copy.image.blob.key)
end
end
end
Expand Down
7 changes: 5 additions & 2 deletions spec/requests/katalyst/content/items_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
shared_examples "has attachment" do |attribute = :image|
it "saves #{attribute}" do
action
expect(ActiveStorage::Blob.service).to be_exist(assigns(:item).send(attribute).blob.key)
expect(ActiveStorage::Blob.service).to exist(assigns(:item).send(attribute).blob.key)
end
end

shared_examples "changes attachment" do |attribute = :image|
it "saves #{attribute}" do
action
expect(ActiveStorage::Blob.service).to be_exist(assigns(:item).send(attribute).blob.key)
expect(ActiveStorage::Blob.service).to exist(assigns(:item).send(attribute).blob.key)
end

it "changes #{attribute}" do
Expand Down Expand Up @@ -72,8 +72,11 @@

it "stores the attachment's id in the form" do
action
# note: response.parsed_body strips out <template> tags
# rubocop:disable Rails/ResponseParsedBody
inputs = Capybara::Node::Simple.new(Nokogiri::HTML5.parse(response.body))
.all("input[name='item[image]']", visible: false)
# rubocop:enable Rails/ResponseParsedBody
expect(inputs).to include(have_attributes(value: assigns(:item).image.signed_id))
end
end
Expand Down
38 changes: 19 additions & 19 deletions spec/system/katalyst/content/editor/container_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
expect(page).to have_css("[data-controller$='list'] li[data-content-item]")

fill_in "Heading", with: "Magic"
click_button "Done"
click_on "Done"

expect(page).to have_css("li", text: "Magic")

click_button "Publish"
click_on "Publish"

expect(page).to have_link(class: "status-text", text: "Published", visible: :visible)

Expand All @@ -47,7 +47,7 @@

expect(page).to have_css("span", class: "status-text", text: "Unsaved changes", visible: :visible)

click_button "Publish"
click_on "Publish"

expect(page).to have_link(class: "status-text", text: "Published", visible: :visible)

Expand All @@ -66,13 +66,13 @@

find("a[title='Edit']").click
fill_in "Heading", with: "Updated"
click_button "Done"
click_on "Done"

expect(page).to have_css("#items_page_#{container.id} > li", text: "Updated")

expect(page).to have_css("span", class: "status-text", text: "Unsaved changes", visible: :visible)

click_button "Publish"
click_on "Publish"

expect(page).to have_link(class: "status-text", text: "Published", visible: :visible)

Expand All @@ -97,12 +97,12 @@
first.drag_to(last)

# check that items have been re-ordered (implicit wait)
expect(page).to have_selector("li[data-content-index='1'][data-content-item-id='#{items.first.id}']")
expect(page).to have_css("li[data-content-index='1'][data-content-item-id='#{items.first.id}']")

# check that state has changed
expect(page).to have_css("span", class: "status-text", text: "Unsaved changes", visible: :visible)

click_button "Publish"
click_on "Publish"

expect(page).to have_link(class: "status-text", text: "Published", visible: :visible)

Expand All @@ -124,7 +124,7 @@

expect(page).to have_css("span", class: "status-text", text: "Unsaved changes", visible: :visible)

click_button "Publish"
click_on "Publish"

expect(page).to have_link(class: "status-text", text: "Published", visible: :visible)

Expand All @@ -141,7 +141,7 @@

visit admin_page_path(container)

expect(page).not_to have_css("li[data-content-item]:not([data-deny-nest]")
expect(page).to have_no_css("li[data-content-item]:not([data-deny-nest]")
end

it "can save without publishing" do
Expand All @@ -152,11 +152,11 @@

find("a[title='Edit']").click
fill_in "Heading", with: "Updated"
click_button "Done"
click_on "Done"

expect(page).to have_css("#items_page_#{container.id} > li", text: "Updated")

click_button "Save"
click_on "Save"

expect(page).to have_link(class: "status-text", text: "Draft", visible: :visible)

Expand All @@ -173,12 +173,12 @@

find("a[title='Edit']").click
fill_in "Heading", with: "Updated"
click_button "Done"
click_on "Done"

expect(page).to have_css("#items_page_#{container.id} > li", text: "Updated")
container.items.reload.destroy_all

click_button "Save"
click_on "Save"

expect(page).to have_text("Items are missing or invalid")
expect(page).to have_css("span", class: "status-text", text: "Unsaved changes", visible: :visible)
Expand All @@ -192,15 +192,15 @@

find("a[title='Edit']").click
fill_in "Heading", with: "Updated"
click_button "Done"
click_on "Done"

expect(page).to have_css("#items_page_#{container.id} > li", text: "Updated")

click_button "Save"
click_on "Save"

expect(page).to have_link(class: "status-text", text: "Draft", visible: :visible)

click_button "Revert"
click_on "Revert"

expect(page).to have_link(class: "status-text", text: "Published", visible: :visible)

Expand All @@ -217,15 +217,15 @@

find("a[title='Edit']").click
fill_in "Heading", with: "Updated"
click_button "Done"
click_on "Done"

expect(page).to have_css("#items_page_#{container.id} > li", text: "Updated")

click_button "Save"
click_on "Save"

expect(page).to have_link(class: "status-text", text: "Draft", visible: :visible)

click_button "Publish"
click_on "Publish"

expect(page).to have_link(class: "status-text", text: "Published", visible: :visible)

Expand Down
Loading
Loading