Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dummy app and compatibility to rails 7.2 #72

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Upgrade dummy app and compatibility to rails 7.2 #72

merged 6 commits into from
Sep 17, 2024

Conversation

sfnelson
Copy link
Contributor

No description provided.

AlanCornthwaiteKatalyst
AlanCornthwaiteKatalyst reviewed Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@AlanCornthwaiteKatalyst AlanCornthwaiteKatalyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a small typo and 1 question re puma thread counts.

spec/dummy/config/puma.rb Show resolved Hide resolved
app/controllers/katalyst/content/items_controller.rb Outdated Show resolved Hide resolved
@sfnelson sfnelson merged commit 11b8bcb into main Sep 17, 2024
1 check passed
@sfnelson sfnelson deleted the upgrade/rails-7.2 branch September 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobakasu sobakasu sobakasu left review comments

@hasarindaKI hasarindaKI hasarindaKI approved these changes

@AlanCornthwaiteKatalyst AlanCornthwaiteKatalyst AlanCornthwaiteKatalyst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfnelson @sobakasu @AlanCornthwaiteKatalyst @hasarindaKI