Fixes for rails 7.1 (Koi 2.6 branch) #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobakasu
force-pushed
the
feature/2.6-rails-7.1
branch
from
6cd9931 to
587d8b4
Compare
sfnelson
approved these changes
Nov 13, 2023
|
I've tested these changes with PFW main branch (rails 7.0) and it's compatible with rails 7.0 also. |
hasarindaKI
approved these changes
Dec 11, 2023
sobakasu
force-pushed
the
feature/2.6-rails-7.1
branch
from
587d8b4 to
85d9c10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing protect_from_forgery in
Koi::ApplicationControllerwe have a
skip_before_action :verify_authenticity_tokeninKoi::UploadsController. This throws an error in rails 7.1 if not usingprotect_from_forgery.Alternative approach would be to remove the
skip_before_action :verify_authenticity_tokenfromKoi::UploadsController. Seems like we should be using protect_from_forgery though.