Feature: MFA for admins #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfnelson
force-pushed
the
feature/mfa
branch
from
cccb39f to
eb3647c
Compare
mattr
approved these changes
Dec 16, 2024
Comment on lines
+75
to
+70
| drift_ahead: 15, | ||
| drift_behind: 15, |
There was a problem hiding this comment.
(opt) Use constants for magic numbers
| redirect_to(url_from(params[:redirect].presence) || admin_dashboard_path, status: :see_other) | ||
| else | ||
| admin_user = Admin::User.new | ||
| admin_user.errors.add(:email, "Invalid token") |
There was a problem hiding this comment.
(opt) If we use a locale entry, it should be possible to overwrite this on a per-app basis
| redirect_to(url_from(params[:redirect].presence) || admin_dashboard_path, status: :see_other) | ||
| else | ||
| admin_user = Admin::User.new | ||
| admin_user.errors.add(:email, "Invalid login credentials") |
sfnelson
force-pushed
the
feature/mfa
branch
from
eb3647c to
c82b38b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.