Allow turbo frame updates inside kpop modals

katalyst · Nov 26, 2024 · 779f0cc · 779f0cc
1 parent 85516ff
commit 779f0cc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    katalyst-kpop (3.2.3)
+    katalyst-kpop (3.2.4)
       katalyst-html-attributes
       turbo-rails
       view_component

diff --git a/app/javascript/kpop/controllers/frame_controller.js b/app/javascript/kpop/controllers/frame_controller.js
@@ -118,6 +118,8 @@ export default class Kpop__FrameController extends Controller {
   beforeFrameRender(event) {
     this.debug("before-frame-render", event.detail.newFrame.baseURI);
 
+    if (event.detail.newFrame.id !== this.element.id) return;
+
     event.preventDefault();
 
     this.dismiss({ animate: true, reason: "before-frame-render" }).then(() => {

diff --git a/katalyst-kpop.gemspec b/katalyst-kpop.gemspec
@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name    = "katalyst-kpop"
-  spec.version = "3.2.3"
+  spec.version = "3.2.4"
   spec.authors = ["Katalyst Interactive"]
   spec.email   = ["[email protected]"]